ci: add lint and package tarball checks - #15
Merged
Conversation
Adds ESLint (typescript-eslint recommended, with any/unused-vars relaxed for this codebase's existing idioms) and publint + npm pack --dry-run to catch package.json/exports and tarball content issues, alongside the existing typecheck and test steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
typescript-eslintrecommended) aspnpm lint, wired into.github/workflows/ci.yml.no-explicit-anyis off (ts-proto message types and Fleet API JSON payloads are inherently untyped) andno-unused-varsallows an_-prefixed convention already used across the codebase for intentionally-unused args.src/teslafleetapi.ts,src/vehiclespecific.ts, two test files) - no behavior change.publintandnpm pack --dry-runas CI steps to catchpackage.json/exportsmistakes and unexpected tarball contents before publish.tsc --noEmitandpnpm teststeps are unchanged.